Make language sync support creating blank language files; clarify lang/README-programmers.txt #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two translators thus far have tried to populate initial language files by creating a blank folder and then using the in-game sync option. For example, see TerryCavanagh#1078. That is not how the sync option was intended to be used, but it's really close to getting everything, so I decided to just complete the support by making sure numbers.xml is copied from English, and making sure meta.xml is filled in with English text and not text from an arbitrary language. Also, minor detail on plural form 1 being set to 1 by default if reset, so strings_plural.xml is fully consistent too.
The top of the programmers readme now says that you need the translators readme to translate the game into a new language. Also, since language file syncing now works to populate an empty language folder, document that in the translators readme as well.
InfoTeddy
added
the
localization
InfoTeddy
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Two translators thus far have tried to populate initial language files by creating a blank folder and then using the in-game sync option. For example, see #1078.
That is not how the sync option was intended to be used, but it's really close to getting everything, so I decided to just complete the support by making sure
numbers.xmlis copied from English, and making suremeta.xmlis filled in with English text and not text from an arbitrary language. Also, minor detail on plural form 1 being set to 1 by default if reset, sostrings_plural.xmlis fully consistent too.The top of lang/README-programmers.txt now also says that you need the translators readme to translate the game into a new language.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes