Some fixes to the translator credits #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header "Translators", as well as the language names, were using PR_FONT_8X8, even though it was translatable text. This is now fixed. (Also, the CJK spacing for the language names is now higher because that looked nicer)
If you go into the middle of the list of translators in the main menu credits, then press Escape, and then go into the credits again, the first page of the list may start at the wrong place, because while game.translator_credits_pagenum was reset to 0, game.current_credits_list_index wasn't. This is fixed now.
The new localization-related credits are placed 5 characters from the left border in the rolling credits (at x=40), which means the limit was 35 8x8 characters. Which was broken by several languages. So instead, move the string leftward a bit if it would run offscreen otherwise.
Luckily, seems like no language has broken the limit when it is 40!
This used 2-space indentation for one level, as well as }else{ on a
single line.
InfoTeddy
added
the
localization
InfoTeddy
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
max="40") to the translator credits stringsLegal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes