Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark remembers 'all schemes' checkbox rather than actual selections #99

Open
matt-dray opened this issue Dec 5, 2024 · 0 comments
Labels
bug Something isn't working should MoSCoW priority
Milestone

Comments

@matt-dray
Copy link
Contributor

It's expected behaviour in retrospect, but the bookmark will return all sites if the 'all sites' checkbox was checked, even if the user removed sites from the 'sites to visualise' box before clicking the bookmarks button. The checkbox state is the thing 'remembered' by the bookmark, so it will overwrite whatever scheme selections were actually made.

Perhaps it shouldn't be a checkbox, but buttons to 'add all' and/or 'clear all'. That way the checkbox can't take precedence over the pool of selected schemes.

(Or maybe there's something about the ordering of elements that means that this wouldn't be a problem if the checkbox was 'before' (i.e. above) the 'schemes to visualise' box.)

Example. Schemes selected before clicking bookmarks button:

Image

And then when returning to the app using the generated bookmarks URL:

Image

@matt-dray matt-dray added bug Something isn't working should MoSCoW priority labels Dec 5, 2024
@matt-dray matt-dray added this to the Backlog milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working should MoSCoW priority
Projects
None yet
Development

No branches or pull requests

1 participant