43 Marvellous Mitigator Pick-n-Mix Selection box 🍬 #98
Conversation
…lection approach. These are hard-coded as the version of {datamods} from CRAN interferes with bslib components - specifically the cards lose their ability fill the page.
…ion to filter and pick mitigators, an action button to add the picked mitigators to the list of selected mitigators and a 'selectizeInput()` object to list the selected mitigators with the option to click to remove any unwanted ones.
…gators()` takes the mitigator_lookup and prepares it for use in the app, `add_to_selected_mitigators()` adds any newly-selected mitigators to the selected mitigator list.
…or selections ui and comments-out code that drove the previoius mitigator selection process and adds an shiny::observeEvent triggered by the new action button to add mitigators to the selected list.
… {datamods} to drive the select_group_ui/server
…xamples that aren't imported here
|
Thank you Craig, as ever! You did a live demo earlier today and we chatted about it. Two features we noted:
We also discussed:
As mentioned, I'm going to try deploying this branch now to see if the bookmarking works as intended in a production environment. I think that needs to be confirmed before merging, and before committing anything related to (1) and (2) above. |
|
Ah, I'm a fool, Shiny server bookmarking works locally (a (In doing this I also spotted a small bookmarks-related issue: it's expected behaviour in retrospect, but the bookmark will return all sites if the 'all sites' checkbox was checked, even if the user removed sites from the 'sites to visualise' box before clicking the bookmarks button. I'll record that separately.) (I also typed 'borkmarks' accidentally when writing this, which seems apt!) |
|
Thank you very much for deploying and testing out the bookmarks feature. I'm relieved it is mostly working as expected - and I had no idea the bookmarking works locally too! |
- changes to on-the-fly calculation of mixture distributions, - updates 'add mitigator' button label to include a count of mitigators that are in-scope to be added to the selected list, - adds observeEvent handle clearing selected mitigators on button click, - increases default height for heatmap plots to accomodate new schemes with longer names
- adds space between 'reset filters' and 'add to selection' button, - changes 'add to selection' button to use shiny library with a light colouring as more compatible with server-side updates to button label, - adds action link to clear the list of selected mitigators.
…tor_code}]') for lookup list to allow for searching for mitigators by code and ensure compatibility between available mitigator and selected mitigator lists.
AdditionsThese additional commits include:
Additional benefits include:
|
|
@Fikriyudin11 - just a bookmark of the mitigator selection functionality I mentioned yesterday that might be a good idea to review in the new year if we go down the route of making an app for comparing the mitigator impacts under scenarios. Craig has provided very illustrative figures at the top and commentary. |
closes #43
Alternative approach to selecting mitigators
This PR offers an alternative approach to selecting mitigators by replacing the carefully curated list of mitigators with the freedom to make your own.
Benefits:
🍫 Freedom to create your own list of mitigators,
🍬 Finding mitigators is made easy by using the interrelated filters and search boxes,
🍭 Mitigators can be quickly un-selected by clicking the 'x' in each tag.
Known issues:
cards()to fill the screen. The GitHub version does not do this, so presumably this will eventually make it to the CRAN version too.To do: