Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GH action for CD on pull request #165

Merged
merged 3 commits into from
Feb 4, 2025
Merged

add GH action for CD on pull request #165

merged 3 commits into from
Feb 4, 2025

Conversation

yiwen-h
Copy link
Member

@yiwen-h yiwen-h commented Jan 3, 2025

closes #153

@yiwen-h yiwen-h self-assigned this Jan 3, 2025
@yiwen-h
Copy link
Member Author

yiwen-h commented Jan 6, 2025

Have something that works and deploys here
Issues:

if there's more than one PR, the most recent one will overwrite the older one
The URL doesn't automatically appear in the PR in the same nice way that it does in the data_science action; is this important?

@yiwen-h yiwen-h requested a review from StatsRhian January 6, 2025 09:35
@StatsRhian
Copy link
Member

The over-writing is not ideal and could be a bit confusing. But I don't know how to recreate the "nice" GHA on DS on here yet.

So yeah let's just go for it?

@yiwen-h yiwen-h merged commit 1d4e31d into main Feb 4, 2025
1 check passed
@yiwen-h yiwen-h deleted the 153_branch-preview branch February 4, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate branch-preview for quarto websites
2 participants