feat(ldapquery): add support multiple search fields #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the possibility of defining multiple UID search fields which will result in a LDAP query checking for the given data in all those fields. This greatly increases the flexiblity of using this analyzer for checking multiple different input data. E.g. given the following real life example. Organization defines users with different identifiable user references such as ([username] userx, [username] [email protected], [email] [email protected], [email] [email protected]). Those user references are all different fields within LDAP. Also alerts, such as in TheHive, generates a variarety of those datatypes as observables. With the previous version of LDAPquery it was not possible to check all possible fields resulting in manually changing all the observables to follow a specific user reference With this version it is possible use the LDAPQuery analyzer for all those use cases by simply adding more relevant UID Search fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the possibility of defining multiple UID search fields which will result in a LDAP query checking for the given data in all those fields. This greatly increases the flexiblity of using this analyzer for checking multiple different input data.
E.g. given the following real life example. Organization defines users with different identifiable user references such as ([username] userx, [username] [email protected], [email] [email protected], [email] [email protected]). Those user references are all different fields within LDAP. Also alerts, such as in TheHive, generates a variarety of those datatypes as observables. With the previous version of LDAPquery it was not possible to check all possible fields resulting in manually changing all the observables to follow a specific user reference
With this version it is possible use the LDAPQuery analyzer for all those use cases by simply adding more relevant UID Search fields.