Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G3-457: Fixing get similar Genesets button #22

Merged
merged 2 commits into from
Sep 20, 2024
Merged

G3-457: Fixing get similar Genesets button #22

merged 2 commits into from
Sep 20, 2024

Conversation

bergsalex
Copy link
Collaborator

No description provided.

@bergsalex bergsalex temporarily deployed to jax-cluster-dev-10--dev September 20, 2024 11:45 — with GitHub Actions Inactive
@bergsalex bergsalex temporarily deployed to jax-cluster-dev-10--dev September 20, 2024 11:54 — with GitHub Actions Inactive
@bergsalex bergsalex requested review from a team, obwalton, gerring, francastell, robyn-ball, rjbluis, JasonBubier1976 and C-1337ka and removed request for a team September 20, 2024 12:32
@bergsalex bergsalex marked this pull request as ready for review September 20, 2024 12:32
@bergsalex bergsalex changed the title Fixing get_geneset_hom_ids for use with multiple hom_ids G3-457: Fixing get similar Genesets button Sep 20, 2024
@bergsalex bergsalex requested a review from TessaNM September 20, 2024 12:58
TessaNM
TessaNM reviewed Sep 20, 2024
View reviewed changes
Copy link

@TessaNM TessaNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to find a single geneset that shows homology with other species in Dev... Wondering if that part of Dev is working and if that might affect the similar genesets button? I get: "The Geneset does not contain any genes. Please update the genes associated with the set and re-run." when I click the similar genesets button. There are genes in the genesets, but no homology info in Dev.

@bergsalex
Copy link
Collaborator Author

I haven't been able to find a single geneset that shows homology with other species in Dev... Wondering if that part of Dev is working and if that might affect the similar genesets button? I get: "The Geneset does not contain any genes. Please update the genes associated with the set and re-run." when I click the similar genesets button. There are genes in the genesets, but no homology info in Dev.

I had the same experience. This is likely because of the work we're doing to update the source data on dev.

I've tested these changes on the SQA database manually, and at the very least this PR fixes some of the issues related to the similar Genesets functionality.

@bergsalex bergsalex requested a review from TessaNM September 20, 2024 13:11
@bergsalex bergsalex merged commit 1c12d28 into main Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TessaNM TessaNM TessaNM approved these changes

@obwalton obwalton Awaiting requested review from obwalton obwalton was automatically assigned from TheJacksonLaboratory/geneweaver

@gerring gerring Awaiting requested review from gerring gerring was automatically assigned from TheJacksonLaboratory/geneweaver

@francastell francastell Awaiting requested review from francastell francastell was automatically assigned from TheJacksonLaboratory/geneweaver

@robyn-ball robyn-ball Awaiting requested review from robyn-ball robyn-ball was automatically assigned from TheJacksonLaboratory/geneweaver

@rjbluis rjbluis Awaiting requested review from rjbluis rjbluis was automatically assigned from TheJacksonLaboratory/geneweaver

@JasonBubier1976 JasonBubier1976 Awaiting requested review from JasonBubier1976 JasonBubier1976 was automatically assigned from TheJacksonLaboratory/geneweaver

@C-1337ka C-1337ka Awaiting requested review from C-1337ka C-1337ka was automatically assigned from TheJacksonLaboratory/geneweaver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergsalex @TessaNM