Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Workflows: Include dash delimiter for projects #28985

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

MaoShizhong
Copy link
Contributor

@MaoShizhong MaoShizhong commented Oct 21, 2024

Because

In #28843, the project lint workflow needed to include _ in the path filtering as for some reason it was matching false positives without it (still not entirely sure why). But it seems not all lesson files use snake case - some use kebab case (like the lesson files in foundations/html_css) and so cause projects to trigger the lesson lint workflow instead (seen in #28983).

It's less disruptive to just include - in the project workflow path filtering than unify the file name casing (which would require changes to the website repo lessons list too).

This PR

  • Includes project- in the project linting workflow path filtering

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@Asartea
Copy link
Contributor

Asartea commented Nov 17, 2024

LGTM

@JoshDevHub JoshDevHub merged commit 2c5059c into TheOdinProject:main Nov 25, 2024
1 check passed
@MaoShizhong MaoShizhong deleted the workflow-project-lint branch November 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants