Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript Time Complexity: Fix Typo #29025

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

looonnng
Copy link
Contributor

Because

currentNumber on line 54 is missing backticks, which made it looks inconsistent.
image

This PR

  • Add backticks to currentNumber

Issue

Closes #XXXXX

Additional Information

Small fix so I didn't want to open an Issue, which means I couldn't give the Close# above.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Oct 30, 2024
@MaoShizhong
Copy link
Contributor

Just realised and checked after approving, could you apply the same fix to the Ruby version of this lesson?

@looonnng
Copy link
Contributor Author

Done! Let me know if I could help with anything else :)

@MaoShizhong MaoShizhong merged commit c1b1407 into TheOdinProject:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants