Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoR: Update link in Active Record Associations #29046

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

WongYC-66
Copy link
Contributor

@WongYC-66 WongYC-66 commented Nov 3, 2024

Because

Ruby on rails official guide has structure change from v7.1 to v7.2

This is about assignment 3.

Skim chapter 4. It contains all the methods that you gain by using various associations. You certainly don’t need to memorize the whole list, but poke through it. You’ll end up using most of them.

I believe the assignment is referring to v7.1 #section 4

This PR

  • Update a link in assignment, to use guide of v7.1

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Nov 3, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to change the instructions in the assignment to fit the new structure of the guide rather than backlink to an older version.

Changing the instructions to something like this would work for getting all the same information that the assignment did with the previous structure of the guide:

1. Read the [Rails Guide on Associations](https://guides.rubyonrails.org/association_basics.html). Start by skimming chapters 1 and 2 (which you should have already done).
2. Read all the content in chapters 3, 4, and 7.

@JoshDevHub JoshDevHub self-assigned this Nov 4, 2024
@WongYC-66
Copy link
Contributor Author

Updated as @JoshDevHub suggested.

@JoshDevHub JoshDevHub merged commit a1fddd2 into TheOdinProject:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants