-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Lesson: Basic REST API #29090
base: main
Are you sure you want to change the base?
New Lesson: Basic REST API #29090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work overall. I suggested a few minor changes to improve the flow and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the article and it's looking great. I've made a few corrections and grammar improvement suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: this lesson uses the term URI 4 times, and URL 9 times. Is there (for the content of this lesson) a meaningful difference expressed with that? Otherwise it should be probably use one of those consistently.
Excluding that and a few minor nits I think overall it looks great
Co-authored-by: Asartea <[email protected]> Co-authored-by: Mayada <[email protected]> Co-authored-by: Henrique Heron <[email protected]>
Co-authored-by: Mayada <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few other small tweaks for readability.
Co-authored-by: Mayada <[email protected]>
Apologies for the delay. Completely forgot about it. |
Because
New lesson on Basic REST APIs. Part of Milestone
#2
of the Node Revamp.This PR
#2
.Issue
Closes #28832
Additional Information
The Markdown Preview tool does not render the nested list under assignments and tables properly. The style for those was copied from other, currently active lessons.
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section