Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Lesson: Basic REST API #29090

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

Lofty-Brambles
Copy link
Contributor

@Lofty-Brambles Lofty-Brambles commented Nov 17, 2024

Because

New lesson on Basic REST APIs. Part of Milestone #2 of the Node Revamp.

This PR

  • Adds a fresh lesson as a part of the Node Revamp Milestone #2.

Issue

Closes #28832

Additional Information

The Markdown Preview tool does not render the nested list under assignments and tables properly. The style for those was copied from other, currently active lessons.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Nov 17, 2024
Copy link
Contributor

@Maddily Maddily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall. I suggested a few minor changes to improve the flow and clarity.

nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@autotelico autotelico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the article and it's looking great. I've made a few corrections and grammar improvement suggestions.

nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Asartea Asartea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: this lesson uses the term URI 4 times, and URL 9 times. Is there (for the content of this lesson) a meaningful difference expressed with that? Otherwise it should be probably use one of those consistently.

Excluding that and a few minor nits I think overall it looks great

nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Show resolved Hide resolved
Copy link
Contributor

@Maddily Maddily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few other small tweaks for readability.

nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
nodeJS/apis/RESTful_APIs.md Outdated Show resolved Hide resolved
@01zulfi 01zulfi added the Project Node Revamp Issues/PRs related to the Node Revamp project label Dec 11, 2024
@Lofty-Brambles Lofty-Brambles requested a review from 01zulfi January 3, 2025 17:35
@Lofty-Brambles
Copy link
Contributor Author

Apologies for the delay. Completely forgot about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course Project Node Revamp Issues/PRs related to the Node Revamp project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Lesson: RESTful APIs
6 participants