Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript and Ruby project-hashmap fix: replace wrong examples with correct ones in collision section #29282

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Punith1117
Copy link
Contributor

Because

The previous examples - 'Carla' and 'Carlos' were not hashed to 3. So, they are replaced with correct examples - 'Ram' and 'Sita'.

This PR

  • Replaces the examples with correct ones
  • Carla and Carlos is replaced by Rama and Sita

Issue

Closes #29210

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

The previous examples - 'Carla' and 'Carlos' were not hashed to 3. So, they are replaced with correct examples - 'Rama' and 'Sita'.
@github-actions github-actions bot added Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course labels Jan 4, 2025
@JoshDevHub JoshDevHub self-requested a review January 4, 2025 16:51
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshDevHub JoshDevHub merged commit 64f5790 into TheOdinProject:main Jan 4, 2025
3 checks passed
@Punith1117 Punith1117 deleted the fix-collision-examples branch January 6, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript: Project HashMap - wrong examples
2 participants