Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper JSDocs to my compat script for Create: Steam & Rails #1462

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

TheDogOfChaos
Copy link
Contributor

I also added comments to break up the wall of tag-adding code, as well as clarify a couple ambiguous things.

For the bunch of function calls at the bottom of the file, I took them out of their blocks, and added comments to break up that wall of code as well.

lmk if any revisions are needed

@Xefyr0 Xefyr0 merged commit 8593356 into ThePansmith:main Feb 6, 2025
1 check passed
Xefyr0 added a commit that referenced this pull request Feb 7, 2025
* Translated using Weblate (Russian)

Currently translated at 36.6% (1250 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/ru/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 96.3% (3289 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 96.3% (3289 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Switch microminers from chanced consumption to repair

* Tweaks to missions that return Neutronium

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 97.2% (3319 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 97.2% (3319 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 97.9% (3344 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 97.9% (3344 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.1% (3350 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.1% (3350 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.2% (3352 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.2% (3352 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.2% (3354 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.4% (3359 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.4% (3359 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.5% (3364 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.5% (3364 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.7% (3369 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 98.7% (3369 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Tweak repair probabilities

* Change Gem Sensor to be cheaper now that it's used more per ore

* Reduce dilithium returned from dilithium mission now that less is consumed as fuel

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (470 of 470 strings)

Co-authored-by: forteen14desu <[email protected]>
Co-authored-by: quettalum <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/monifactory/kubejs/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/
Translation: Monifactory/KubeJS
Translation: Monifactory/Questbook

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (9 of 9 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (9 of 9 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (15 of 15 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (10 of 10 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (434 of 434 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 99.7% (469 of 470 strings)

Co-authored-by: forteen14desu <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/monifactory/gregtech/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/kubejs/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/mods/emi/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/mods/enderio/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/mods/extended-crafting/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/mods/laserio/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/
Translation: Monifactory/EMI
Translation: Monifactory/EnderIO
Translation: Monifactory/Extended Crafting
Translation: Monifactory/Gregtech
Translation: Monifactory/KubeJS
Translation: Monifactory/LaserIO
Translation: Monifactory/Questbook

* Reduce quantity of Alien Scrap returned from T11 now that it's repairable

* Simplify mission definitions and fix half-tier actualization bug

* Lint

* fix projectred plate recipe conflicting with smooth stone slab (#1478)

* Allow any type of rubber in thermal recipes. (#1470)

This is particularly useful for the alchemical quiver used in the
T2.5MM (from #1477).

* Reduce repair times so that repairs are as fast as missions in higher tiers and even faster in lower tiers.

* Fluid Rig quest change (#1483)

indicates the you can now get regular oil in the void
no longer says oil in the void doesn't deplete

* Translated using Weblate (Russian)

Currently translated at 37.6% (1284 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/ru/

* Account for tick-second conversion in new repair times (Amended commit)

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Tweak repair overclock cost decreases

* Re-add Neutronium to T8MM mission for MkIII skip

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (470 of 470 strings)

Co-authored-by: forteen14desu <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/monifactory/kubejs/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/
Translation: Monifactory/KubeJS
Translation: Monifactory/Questbook

* Post-tank mats frames on multiblocks (#1486)

They look good :3

* Stonecut GTCEU warning blocks into each other (#1439)

For parity with Chisel.

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translation: Monifactory/Questbook
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/

* Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (3413 of 3413 strings)

Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (470 of 470 strings)

Co-authored-by: forteen14desu <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/monifactory/kubejs/zh_Hans/
Translate-URL: https://hosted.weblate.org/projects/monifactory/questbook/zh_Hans/
Translation: Monifactory/KubeJS
Translation: Monifactory/Questbook

* Usable complex SMDs  (#1484)

* Craft for basic capacitor with complex smd

* Type definitions for GT JSON recipes

* Automatically generate recipes with complex SMDs

* Mention the change in QB

* Simplify naquadah energy values. (#1472)

* Added tooltip for damaged MMs

* Added proper JSDocs to my compat script for Create: Steam & Rails (#1462)

* add some comments to break up the wall of code here into manageable segments

* did proper JSDocs for my functions here, hopefully they'll be useful to future maintainers

* clarification on the cutter chanced output for narrow-gauge

---------

Signed-off-by: Becquerel <[email protected]>

* Replace repair for T1-5MMs and some higher-tier missions with consumable kits which are easier to automate

* Integral components-based programmer art for microminer kits

* Lint

---------

Signed-off-by: Becquerel <[email protected]>
Co-authored-by: Денис Денис <[email protected]>
Co-authored-by: quettalum <[email protected]>
Co-authored-by: hyl5942850 <[email protected]>
Co-authored-by: forteen14desu <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: medsal15 <[email protected]>
Co-authored-by: Tom Prince <[email protected]>
Co-authored-by: Jollahs <[email protected]>
Co-authored-by: WithersChat <[email protected]>
Co-authored-by: petrak@ <[email protected]>
Co-authored-by: iluha168 <[email protected]>
Co-authored-by: Pansmith <[email protected]>
Co-authored-by: Becquerel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants