Copy lvalues instead of referencing them #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signal::connect has been reworked. It now does one of the following 3: * Stores a function pointer if the callable can be converted to one * Constructs the callable in the pointer's memory via perfect forwarding * Constructs the callable on the heap via perfect forwarding One relevant test in main.cpp has been updated, and a memory leak in another test was fixed. Also marks conn_nontrivial destructor as an override Fixes TheWisp#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is of interest, I've made an attempt at resolving #20. I can't say I'm 100% confident in this code, but the basic test suite passes (with address/undefined behavior sanitizers). Thanks!
signal::connect has been reworked. It now does one of the following 3:
One relevant test in main.cpp has been updated, and a memory leak in another
test was fixed.
Also marks conn_nontrivial destructor as an override