Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grep issue with backslashes and update package structure #271

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

statnmap
Copy link
Collaborator

Address a regex issue in the grep function on Windows, enhance package styling, and improve testing interactivity. Update package dependencies and documentation accordingly.

On CRAN on windows:
Error in `grep(flat_file, lines)`: invalid regular expression 'D:\temp\2025_01_08_01_50_00_5874\RtmpwHf2oC\rename97d8768121eb/dev/flat_full.Rmd', reason 'Invalid back reference'

=> grep() considers '\2' to reference an object as by default it can accept a regex.
=> Fix : grep(flat_file, lines, fixed = TRUE)
@VincentGuyader
Copy link
Member

thanks a lot

Copy link
Member

@VincentGuyader VincentGuyader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@statnmap statnmap merged commit 1048139 into main Jan 13, 2025
10 checks passed
@statnmap statnmap deleted the fix-windows-path-cran branch January 13, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants