fix Container.default_extensions default value coercion

ThirVondukr · Nov 21, 2024 · da3b56c · da3b56c
1 parent 04cee43
commit da3b56c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/aioinject/containers.py b/aioinject/containers.py
@@ -31,7 +31,11 @@ def __init__(
         *,
         default_extensions: Sequence[Extension] | None = None,
     ) -> None:
-        default_extensions = default_extensions or DEFAULT_EXTENSIONS
+        default_extensions = (
+            default_extensions
+            if default_extensions is not None
+            else DEFAULT_EXTENSIONS
+        )
 
         self._exit_stack = AsyncExitStack()
         self._singletons = SingletonStore(exit_stack=self._exit_stack)

diff --git a/tests/container/test_container.py b/tests/container/test_container.py
@@ -120,3 +120,14 @@ def dependency() -> Iterator[int]:
 
         assert shutdown is False
     assert shutdown is True
+
+
+def test_dependency_extractor_not_found() -> None:
+    provider = Singleton(_ServiceA)
+    container = Container(default_extensions=[])
+    with pytest.raises(ValueError) as err_info:  # noqa: PT011
+        container.register(provider)
+    assert (
+        str(err_info.value)
+        == f"Couldn't find appropriate SupportsDependencyExtraction extension for provider {provider!r}"
+    )