Skip to content

Commit

Permalink
STUDIO_FEATURES
Browse files Browse the repository at this point in the history
  • Loading branch information
Roblox-Thot authored Jul 14, 2024
1 parent ed5457d commit 9d60611
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
12 changes: 0 additions & 12 deletions Bloxstrap/Bootstrapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -531,14 +531,12 @@ public static void CheckInstall()

ProtocolHandler.Register("roblox", "Roblox", Paths.Application);
ProtocolHandler.Register("roblox-player", "Roblox", Paths.Application);
#if STUDIO_FEATURES
ProtocolHandler.Register("roblox-studio", "Roblox", Paths.Application);
ProtocolHandler.Register("roblox-studio-auth", "Roblox", Paths.Application);

ProtocolHandler.RegisterRobloxPlace(Paths.Application);
ProtocolHandler.RegisterExtension(".rbxl");
ProtocolHandler.RegisterExtension(".rbxlx");
#endif

if (Environment.ProcessPath is not null && Environment.ProcessPath != Paths.Application)
{
Expand Down Expand Up @@ -572,9 +570,7 @@ public static void CheckInstall()

Utility.Shortcut.Create(Paths.Application, "", Path.Combine(Paths.StartMenu, "Play Roblox.lnk"));
Utility.Shortcut.Create(Paths.Application, "-menu", Path.Combine(Paths.StartMenu, $"{App.ProjectName} Menu.lnk"));
#if STUDIO_FEATURES
Utility.Shortcut.Create(Paths.Application, "-ide", Path.Combine(Paths.StartMenu, $"Roblox Studio ({App.ProjectName}).lnk"));
#endif

if (App.Settings.Prop.CreateDesktopIcon)
{
Expand Down Expand Up @@ -704,13 +700,11 @@ private void Uninstall()
process.Close();
}

#if STUDIO_FEATURES
foreach (Process process in Process.GetProcessesByName(App.RobloxStudioAppName))
{
process.Kill();
process.Close();
}
#endif
}
catch (Exception ex)
{
Expand Down Expand Up @@ -745,7 +739,6 @@ private void Uninstall()
ProtocolHandler.Register("roblox-player", "Roblox", bootstrapperLocation);
}

#if STUDIO_FEATURES
using RegistryKey? studioBootstrapperKey = Registry.CurrentUser.OpenSubKey(@"Software\Microsoft\Windows\CurrentVersion\Uninstall\roblox-studio");
if (studioBootstrapperKey is null)
{
Expand All @@ -766,7 +759,6 @@ private void Uninstall()

ProtocolHandler.RegisterRobloxPlace(studioLocation);
}
#endif

// if the folder we're installed to does not end with "Bloxstrap", we're installed to a user-selected folder
// in which case, chances are they chose to install to somewhere they didn't really mean to (prior to the added warning in 2.4.0)
Expand Down Expand Up @@ -970,11 +962,7 @@ private async Task InstallLatestVersion()
// delete any old version folders
// we only do this if roblox isnt running just in case an update happened
// while they were launching a second instance or something idk
#if STUDIO_FEATURES
if (!Process.GetProcessesByName(App.RobloxPlayerAppName).Any() && !Process.GetProcessesByName(App.RobloxStudioAppName).Any())
#else
if (!Process.GetProcessesByName(App.RobloxPlayerAppName).Any())
#endif
{
foreach (DirectoryInfo dir in new DirectoryInfo(Paths.Versions).GetDirectories())
{
Expand Down
3 changes: 2 additions & 1 deletion Bloxstrap/RobloxDeployment.cs
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,9 @@ public static string GetLocation(string resource, string? channel = null)
return location;
}

public static async Task<ClientVersion> GetInfo(string channel, bool extraInformation = false, string binaryType = "WindowsPlayer")
public static async Task<ClientVersion> GetInfo(string notusedchannel, bool extraInformation = false, string binaryType = "WindowsPlayer")
{
string channel = DefaultChannel

Check failure on line 116 in Bloxstrap/RobloxDeployment.cs

View workflow job for this annotation

GitHub Actions / build (Debug)

; expected

Check failure on line 116 in Bloxstrap/RobloxDeployment.cs

View workflow job for this annotation

GitHub Actions / build (Debug)

; expected

Check failure on line 116 in Bloxstrap/RobloxDeployment.cs

View workflow job for this annotation

GitHub Actions / build (Release)

; expected

Check failure on line 116 in Bloxstrap/RobloxDeployment.cs

View workflow job for this annotation

GitHub Actions / build (Release)

; expected
const string LOG_IDENT = "RobloxDeployment::GetInfo";

App.Logger.WriteLine(LOG_IDENT, $"Getting deploy info for channel {channel} (extraInformation={extraInformation})");
Expand Down

0 comments on commit 9d60611

Please sign in to comment.