Add range option for download requests #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the option to pass range headers into the download requests so that one may satisfy the datafusion ObjectReader interface with this library that requires a chunked reader option.
|
For reference the gcs adapter I'm working on is here https://github.com/ajroetker/datafusion-objectstore-gcs |
|
@ThouCheese not sure if I need to ping you or anything for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the option to pass range headers into the download requests so that one may satisfy the datafusion ObjectReader interface with this library that requires a chunked reader option.
I'm working on making a GCS version of the S3 datafusion https://github.com/datafusion-contrib/datafusion-objectstore-s3 adapter and using cloud-storage-rs for that.
Mostly a weekend warrior with rust so let me know if this would be sane or if I could do something to improve this!