Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jsonwebtoken version #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gahag-cw
Copy link

@gahag-cw gahag-cw commented Apr 12, 2023

Up to version 7, jsonwebtoken transitively depends on a version of time that has a security vulnerability, which gets reported by dependabot on all Rust repos. As of version 8, this dependency is updated, removing the security warning. This PR solves that by bumping jsonwebtoken to version 8, without changing anything else.

@gahag-cw
Copy link
Author

@ThouCheese can you please approve the workflow? So I can assure the tests are passing.

@ThouCheese
Copy link
Owner

@ThouCheese can you please approve the workflow? So I can assure the tests are passing.

Sure thing!

@gahag-cw
Copy link
Author

Should work now! I'll edit the description with the reasoning for this PR.

@gahag-cw gahag-cw marked this pull request as ready for review April 12, 2023 22:33
@gahag-cw
Copy link
Author

@ThouCheese can you please take a look at this? It's important so that depending on cloud-storage-rs does not trigger dependabot warnings.

@gahag-cw
Copy link
Author

Tests are failing with:

SERVICE_ACCOUNT file not valid: Error("EOF while parsing a value", line: 2, column: 0)

I believe this is unrelated to my changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants