refactor: remove param of transfer thusd ownership function

Threshold-USD · Feb 5, 2024 · 3371b2b · 3371b2b
1 parent c757278
commit 3371b2b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 18 deletions.
diff --git a/packages/contracts/contracts/THUSDOwner.sol b/packages/contracts/contracts/THUSDOwner.sol
@@ -7,9 +7,9 @@ import "./Dependencies/CheckContract.sol";
 import "./Dependencies/Ownable.sol";
 
 contract THUSDOwner is Ownable, CheckContract {
-    ITHUSDToken private thusdToken;
+    ITHUSDToken public immutable thusdToken;
 
-    address public governorBravoAddress;
+    address public immutable governorBravoAddress;
 
     constructor(
         address _governorBravoAddress, 
@@ -35,11 +35,7 @@ contract THUSDOwner is Ownable, CheckContract {
         thusdToken.finalizeRevokeMintList();
     }
 
-    function transferThusdOwnershipToGovernorBravo(address _account) 
-        external 
-        onlyOwner 
-    {
-        require(_account == governorBravoAddress, "THUSDOwner: new owner must be Governor Bravo");
-        thusdToken.transferOwnership(_account);
+    function transferThusdOwnershipToGovernorBravo() external onlyOwner {
+        thusdToken.transferOwnership(governorBravoAddress);
     }
 }
diff --git a/packages/contracts/test/THUSDOwnerTest.js b/packages/contracts/test/THUSDOwnerTest.js
@@ -120,23 +120,13 @@ contract('THUSDOwner', async accounts => {
 
   it('transferThusdOwnershipToGovernorBravo(): reverts when caller is not owner', async () => {
     await assertRevert(thusdOwner.transferThusdOwnershipToGovernorBravo(
-      governorBravo, 
       { from: owner }), 
       "Ownable: caller is not the owner"
     )
   })
-
-  it('transferThusdOwnershipToGovernorBravo(): reverts when new owner is not governor bravo', async () => {
-    await assertRevert(thusdOwner.transferThusdOwnershipToGovernorBravo(
-      owner, 
-      { from: integrationsGuild }), 
-      "THUSDOwner: new owner must be Governor Bravo"
-    )
-  })
 
   it('transferThusdOwnershipToGovernorBravo(): transfer thusd ownership to governor bravo', async () => {
     await thusdOwner.transferThusdOwnershipToGovernorBravo(
-      governorBravo, 
       { from: integrationsGuild }
     )
     await assert.equal(await thusdToken.owner(), governorBravo)