feat: add pricefeed base for redstone adapter #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for app-thresholdusd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying dev with
|
| Latest commit: |
1abeeb0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://99437ca7.dev-e13.pages.dev |
| Branch Preview URL: | https://feat-add-pricefeed-base-for.dev-e13.pages.dev |
evandrosaturnino
changed the title
vzotova
approved these changes
May 17, 2024
evandrosaturnino
deleted the
feat/add-pricefeed-base-for-redstone-pricefeed-adapter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To deploy the Threshold USD contracts on the BOB mainnet, we requested Redstone and Tellor to deploy the price feeds for BTC:USD and ETH:USD pairs on BOB. Redstone deployed an adapter contract that relays the BTC and ETH prices, among other assets, from the mainnet to BOB. You can find the adapter contract here.
The Redstone adapter provides the pair prices in a format different from what our price feed expects. After further inquiries, the Redstone team provided existing audited contracts that should be used for situations where Chainlink compatibility is required. These contracts are PriceFeedBase and PriceFeedWithRounds.
Using the PriceFeedBase and PriceFeedWithRounds contracts as references, this PR introduces a PriceFeedBase contract that will serve as the price aggregator for our Price Feed contract. It will act as a format converter for the Redstone adapter, ensuring it is Chainlink-compatible, as required by our protocol.
Notice
Pull Request Type
Testing Please outline all testing steps
Testing locally:
git clone https://github.com/Threshold-USD/dev.gityarnyarn start-dev-frontend