Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored armor to kits #264

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Colored armor to kits #264

merged 3 commits into from
Jun 17, 2024

Conversation

TiagoFar78
Copy link
Owner

Closes #194

@TiagoFar78 TiagoFar78 added the enhancement New feature or request label Jun 17, 2024
@TiagoFar78 TiagoFar78 self-assigned this Jun 17, 2024
@TiagoFar78 TiagoFar78 requested a review from iquelli June 17, 2024 14:43
@iquelli
Copy link
Collaborator

iquelli commented Jun 17, 2024 •
edited
Loading

LGTM, but could you do git commit messages in the present? LIke "Add .... " instead of "added..."
It's the convention. You don't need to change now, it's just fyi for future commits

@TiagoFar78 TiagoFar78 merged commit db5b460 into master Jun 17, 2024
2 checks passed
@TiagoFar78 TiagoFar78 deleted the coloredArmor branch June 17, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iquelli iquelli iquelli approved these changes

Assignees

@TiagoFar78 TiagoFar78

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Add colored armor to kits
2 participants
@TiagoFar78 @iquelli