Reduce memory usage and improve perf when reading VCF headers #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lumn buffer memory allocation
|
This pull request has been linked to Shortcut Story #38153: VCF memory usage increase when reading non-materialized attributes. |
awenocur
approved these changes
Dec 11, 2023
awenocur
pushed a commit
that referenced
this pull request
Dec 14, 2023
…632) Co-authored-by: George Powley <[email protected]>
awenocur
pushed a commit
that referenced
this pull request
Dec 21, 2023
awenocur
pushed a commit
that referenced
this pull request
Dec 21, 2023
…633) Co-authored-by: George Powley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read VCF headers with the
ManagedQueryAPI which:std::vector<T>::reserve()instead of allocating and populating user buffers. TheManagedQueryuses the actual amount of memory required, while the previous implementation used the entire estimated buffer size, which was pessimistic.This PR also resolves an edge case where reading the first sample would fail if the first sample was previously deleted.