Skip to content

Commit

Permalink
Revert "apacheGH-37983: [JS] create nullable Fields in Table construc…
Browse files Browse the repository at this point in the history
…tor (apache#37982)" (apache#39253)

I missed that the tests were failing.
  • Loading branch information
domoritz authored Dec 16, 2023
1 parent a91a11d commit d918364
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/src/table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class Table<T extends TypeMap = any> {
} else if (typeof x === 'object') {
const keys = Object.keys(x) as (keyof T)[];
const vecs = keys.map((k) => new Vector([x[k]]));
const schema = new Schema(keys.map((k, i) => new Field(String(k), vecs[i].type, true)));
const schema = new Schema(keys.map((k, i) => new Field(String(k), vecs[i].type)));
const [, batches] = distributeVectorsIntoRecordBatches(schema, vecs);
return batches.length === 0 ? [new RecordBatch(x)] : batches;
}
Expand Down

0 comments on commit d918364

Please sign in to comment.