Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the control_device script #825

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

YogevBokobza
Copy link
Collaborator

@YogevBokobza YogevBokobza commented Jan 3, 2025

Description

Fixed #816

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

@pull-request-size pull-request-size bot added the size: l Pull request has 100 to 500 lines label Jan 3, 2025
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (1df1aa6) to head (998435e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #825   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          11       11           
  Lines        1292     1292           
=======================================
  Hits         1279     1279           
  Misses         13       13           

@auto-me-bot auto-me-bot bot added status: approved Pull request is approved and removed status: needs review Pull request needs a review labels Jan 3, 2025
@TomerFi TomerFi changed the title fix: refactoring control device chore: refactor the control_device script Jan 3, 2025
Copy link
Owner

@TomerFi TomerFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auto-me-bot auto-me-bot bot added status: changes requested Pull request changes requested and removed status: approved Pull request is approved labels Jan 3, 2025
@pull-request-size pull-request-size bot added size: xl Pull request has 500 to 1000 lines and removed size: l Pull request has 100 to 500 lines labels Jan 4, 2025
@YogevBokobza YogevBokobza requested a review from TomerFi January 5, 2025 11:33
@YogevBokobza
Copy link
Collaborator Author

Thank you @YogevBokobza . We need to update the docs: https://github.com/TomerFi/aioswitcher/blob/dev/docs/scripts.md too.

It is done :)

Copy link
Collaborator

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YogevBokobza 👍

@TomerFi TomerFi merged commit 98ede26 into TomerFi:dev Jan 7, 2025
10 checks passed
@auto-me-bot auto-me-bot bot added status: merged Pull request merged and removed status: changes requested Pull request changes requested labels Jan 7, 2025
@YogevBokobza YogevBokobza deleted the refactor_control_device_script branch January 7, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request has 500 to 1000 lines status: merged Pull request merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the control device script
3 participants