Skip to content

Commit

Permalink
Fixed docker hub description pushing.
Browse files Browse the repository at this point in the history
  • Loading branch information
TomerFi committed Apr 10, 2020
1 parent 8ff1dc5 commit a842d95
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 56 deletions.
1 change: 0 additions & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ docker-tag-latest: add latest tag before pushing the latest version
docker-run: run the built image as a container (must be built first).
docker-build-and-run: build image from Dockerfile and run as container.
docker-build-no-cache-and-run: build image from Dockerfile with no caching and run as container.
push-description: push the relative README.md file as full description to docker hub, requires username and password arguments
verify-environment-file: verify the existence of the required environment variables file.
```

Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,10 @@ jobs:
tags: latest,${{ steps.getSemver.outputs.semver }}
# yamllint disable-line rule:line-length
build_args: VCS_REF=$GITHUB_SHA,BUILD_DATE=${{ steps.getDate.outputs.date }},VERSION=${{ steps.getSemver.outputs.semver }}

- name: Update docker hub description
uses: peter-evans/dockerhub-description@v2
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
DOCKERHUB_REPOSITORY: tomerfi/switcher_webapi
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,6 @@ docker-build-and-run: docker-build docker-run
docker-build-no-cache-and-run: ## build image from Dockerfile with no caching and run as container.
docker-build-no-cache-and-run: docker-build-no-cache docker-run

push-description: ## push the relative README.md file as full description to docker hub, requires username and password arguments
sh shellscripts/push-docker-description.sh $(strip $(username)) $(strip $(password)) $(strip $(IMAGE_NAME))

verify-environment-file: ## verify the existence of the required environment variables file.
ifndef CONF_DEVICE_IP_ADDR
$(error Mandatory configuration value CONF_DEVICE_IP_ADDR was not provided, can't run container.)
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.3.0
0.3.1
51 changes: 0 additions & 51 deletions shellscripts/push-docker-description.sh

This file was deleted.

0 comments on commit a842d95

Please sign in to comment.