Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Socket class #57

Merged
merged 13 commits into from
Nov 6, 2023
Merged

Add Socket class #57

merged 13 commits into from
Nov 6, 2023

Conversation

TooTallNate
Copy link
Owner

@TooTallNate TooTallNate commented Nov 4, 2023

Adds a Socket class which implements the spec defined in the WinterCG Socket spec.

Switch.connect() has been updated to return an instance of this class as well as match the connect() function defined in that spec.

Internally, fetch() has been updated to leverage the Socket instance, and the "starwars" demo app has also been updated.

Closes #30.

Copy link

changeset-bot bot commented Nov 4, 2023

🦋 Changeset detected

Latest commit: f732816

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
nxjs-runtime Patch
2048 Patch
snake Patch
create-nxjs-app Patch
nxjs-constants Patch
nxjs-pack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 9:00am

@TooTallNate TooTallNate changed the title Add Socket Add Socket class Nov 6, 2023
@TooTallNate TooTallNate marked this pull request as ready for review November 6, 2023 09:08
@TooTallNate TooTallNate merged commit f3b4cc9 into main Nov 6, 2023
3 checks passed
@TooTallNate TooTallNate deleted the socket branch November 6, 2023 09:08
@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Switch.connect() return a Socket instance
1 participant