-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): async adapter #419
Open
Totodore
wants to merge
14
commits into
main
Choose a base branch
from
feat-adapter-rework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(core/adapter): pass filter to get_sids * feat: add custom `Iterator` return for apply_opts fn
Totodore
added
A-core
Area related to socketioxide-core
C-Feature-request
Request for a feature
labels
Jan 1, 2025
* test(e2e): provide e2e testing system for adapters * fix(e2e/adapter): remove redis deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full rework of the async adapter.
The majority of the adapter code is now in the
socketioxide-core
crate. It contains aLocalAdapter
with the following type def:The
SocketEmitter
is an internal interface implemented by thesocketioxide
crate to execute actions on the sockets:The
Adapter
default implementation is the local adapter. Any other implementation that uses remote systems (redis, mongo, ...) can propagate requests and then execute the default behavior with theCoreLocalAdapter
passed to the adapter implementation.