Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted Helm Chart to work with ververica deployment manager #114

Closed
wants to merge 57 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
b4db5f2
Adapted ververica deployemtn to 1.10.1
pielas Sep 18, 2023
b11f668
bump
pielas Sep 18, 2023
a23e64a
wip
pielas Sep 18, 2023
26435b4
bump
pielas Sep 19, 2023
42125c3
Added handling of remote classpath
pielas Sep 19, 2023
7794655
bump
pielas Sep 19, 2023
4d09242
fix
pielas Sep 20, 2023
56e3f99
Removed unnecesary configuration fields
pielas Oct 4, 2023
bdc15ff
fixes
pielas Oct 11, 2023
962e031
Merge remote-tracking branch 'origin/main' into preview/mpk-va-1.11
pielas Oct 11, 2023
c781e56
fix
pielas Oct 11, 2023
689bce7
test
pielas Oct 12, 2023
5cf7fa8
test
pielas Oct 12, 2023
de113a1
tet
pielas Oct 12, 2023
4efdbc1
test
pielas Oct 12, 2023
70cc7c5
test
pielas Oct 12, 2023
642293f
test
pielas Oct 12, 2023
d6b9657
test
pielas Oct 12, 2023
938c463
test
pielas Oct 12, 2023
1ddd229
test
pielas Oct 12, 2023
5032c1b
test
pielas Oct 12, 2023
f89f06e
test
pielas Oct 12, 2023
5efcc81
tets
pielas Oct 12, 2023
a7c821f
test
pielas Oct 12, 2023
24568f1
test
pielas Oct 12, 2023
38113f2
fixes
pielas Oct 17, 2023
b526cd1
fix
pielas Oct 17, 2023
54b8cdc
Merge branch 'preview/main_test' into preview/mpk-va-1.11
pielas Oct 17, 2023
706669c
fix
pielas Oct 17, 2023
64f7733
fix
pielas Oct 17, 2023
f56d443
Potential fix
pielas Oct 17, 2023
2025baf
test
pielas Oct 17, 2023
9fc9813
test
pielas Oct 17, 2023
9f65914
test
pielas Oct 17, 2023
b763597
test
pielas Oct 18, 2023
074c107
Updated deprecated things
pielas Oct 18, 2023
5babe31
test
pielas Oct 18, 2023
b120835
test
pielas Oct 18, 2023
6ebd05c
Merge branch 'main_mpk_test' into preview/mpk-va-1.11
pielas Oct 18, 2023
dbc12ad
fix
pielas Oct 18, 2023
2d4b58c
Added helm check
pielas Oct 18, 2023
102617e
test
pielas Oct 18, 2023
5e6e89b
test
pielas Oct 18, 2023
462abc0
test
pielas Oct 18, 2023
9f70a17
tet
pielas Oct 18, 2023
a1dd13f
test
pielas Oct 18, 2023
47e1565
test
pielas Oct 18, 2023
7b4ee4d
test
pielas Oct 18, 2023
24ae00d
test
pielas Oct 18, 2023
8b57af2
test
pielas Oct 18, 2023
81c180e
Restored -SNAPSHOT
pielas Oct 18, 2023
4e6edc5
Added engineVersion parameter
pielas Oct 25, 2023
81f8c46
Updated helm version
pielas Oct 25, 2023
0421c4e
Added releasing to allow testing this crap
pielas Oct 25, 2023
c0c11fa
Merge remote-tracking branch 'origin/main' into preview/mpk-va-1.11
pielas Oct 25, 2023
a1b976e
fix
pielas Oct 25, 2023
2753f12
Added workspaceId to config
pielas Nov 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions .github/workflows/helm-test-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:
CHART_REPOSITORY_AUTH: "${{ secrets.CHARTS_PUBLIC_AUTH}}"
CHARTS_PUBLIC_SNAPSHOTS_URL: "https://helm-charts.touk.pl/nexus/repository/helm-snapshots/"
CHARTS_PUBLIC_RELEASES_URL: "https://helm-charts.touk.pl/nexus/repository/helm-releases/"

HELM_VERSION: 'version.BuildInfo{Version:"v3.13.1", GitCommit:"3547a4b5bf5edb5478ce352e18858d8a552a4110", GitTreeState:"clean", GoVersion:"go1.20.8"}'
defaults:
run:
shell: bash
Expand All @@ -37,25 +37,28 @@ jobs:
outputs:
version: ${{ steps.setVersion.outputs.version }}
steps:
- name: Verify helm version
run: current_helm_version=$(helm version) && echo "Current helm version $current_helm_version" && [ "$current_helm_version" = "$HELM_VERSION" ] && echo "Helm is in expected version" || echo "::warning title=Helm version is different than expected!::Helm has been updated on runner's image. It could lead to unexpected behaviour during pipeline execution!"
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Print Nussknacker version
run: |
echo "Nussknacker version: $NUSSKNACKER_VERSION"
- name: setVersion
id: setVersion
run: echo "::set-output name=version::$(helm show chart ${{env.CHART_SRC_DIR}} | grep ^version | sed -e "s/.*:\ //;s/SNAPSHOT/SNAPSHOT.${{github.run_id}}/")"
run: echo "version=$(helm show chart ${{env.CHART_SRC_DIR}} | grep ^version | sed -e "s/.*:\ //;s/SNAPSHOT/SNAPSHOT.${{github.run_id}}/")" >> $GITHUB_OUTPUT
- name: buildAll
run: ./setup.sh
- name: checkTemplate
run: helm template -f deploy-values.yaml --set "image.tag=${{env.NUSSKNACKER_VERSION}}" ${{env.CHART_SRC_DIR}}
- name: packageAll
run: helm package ${{env.CHART_SRC_DIR}} -d dist --version "${{steps.setVersion.outputs.version}}"
- name: Store target
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: helm-build
path: "dist/${{env.NAME}}-${{steps.setVersion.outputs.version}}.tgz"
- run: curl -u ${{env.CHART_REPOSITORY_AUTH}} --fail --upload-file "dist/${{env.NAME}}-${{steps.setVersion.outputs.version}}.tgz" ${{env.CHARTS_PUBLIC_SNAPSHOTS_URL}}
test-flink:
name: test flink mode
runs-on: ubuntu-latest
Expand All @@ -64,8 +67,8 @@ jobs:
NUSSKNACKER_VERSION: staging-latest_scala-2.12
steps:
- name: Checkout
uses: actions/checkout@v2
- uses: actions/download-artifact@v2
uses: actions/checkout@v4
- uses: actions/download-artifact@v3
with:
name: helm-build
path: dist
Expand All @@ -86,8 +89,8 @@ jobs:
needs: [ build ]
steps:
- name: Checkout
uses: actions/checkout@v2
- uses: actions/download-artifact@v2
uses: actions/checkout@v4
- uses: actions/download-artifact@v3
with:
name: helm-build
path: dist
Expand All @@ -107,8 +110,8 @@ jobs:
needs: [ build ]
steps:
- name: Checkout
uses: actions/checkout@v2
- uses: actions/download-artifact@v2
uses: actions/checkout@v4
- uses: actions/download-artifact@v3
with:
name: helm-build
path: dist
Expand All @@ -128,7 +131,7 @@ jobs:
runs-on: ubuntu-latest
needs: [ build, test-flink, test-streaming-lite, test-request-response ]
steps:
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v3
with:
name: helm-build
path: dist
Expand Down
8 changes: 4 additions & 4 deletions src/Chart.lock
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ dependencies:
version: 0.2.0
- name: grafana
repository: https://grafana.github.io/helm-charts
version: 6.59.4
version: 6.61.0
- name: influxdb
repository: https://helm.influxdata.com/
version: 4.12.5
- name: telegraf
repository: https://helm.influxdata.com/
version: 1.8.34
digest: sha256:a4235f4aca5b0785f910bc33cb813604cab949729753b88fb095814524fe269c
generated: "2023-09-13T10:29:02.122496096+02:00"
version: 1.8.35
digest: sha256:0f79e72af1530a708dd2b65389dd49a3808c36c750feca6faad8d6ec43ee2ed6
generated: "2023-10-18T09:52:20.811471+02:00"
2 changes: 1 addition & 1 deletion src/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nussknacker
version: 1.11.1
version: 1.11.1-SNAPSHOT-mpk-2
description: Nussknacker - a design, development, and deployment tool for stream processing
home: https://nussknacker.io/
icon: https://nussknacker.io/wp-content/uploads/2021/10/Nussknacker-short-black.svg
Expand Down
2 changes: 2 additions & 0 deletions src/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ nussknacker-request-response-scenario
{{- define "nussknacker.modelClassPath" -}}
{{- if .Values.nussknacker.modelClassPath -}}
{{ tpl ( mustToJson .Values.nussknacker.modelClassPath) . }}
{{- else if eq .Values.nussknacker.mode "ververica" -}}
["model/defaultModel.jar", "model/flinkExecutor.jar", "components/flink", "components/common", "compatibility-provider/nussknacker-ververica-compatibility-provider.jar"]
{{- else if eq .Values.nussknacker.mode "flink" -}}
["model/defaultModel.jar", "model/flinkExecutor.jar", "components/flink", "components/common"]
{{- else if eq .Values.nussknacker.mode "streaming-lite" -}}
Expand Down
14 changes: 13 additions & 1 deletion src/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,19 @@ data:

scenarioTypes {
"default": {
{{- if eq .Values.nussknacker.mode "flink" }}
{{- if eq .Values.nussknacker.mode "ververica" }}
deploymentConfig: {
type: "ververica"
username: {{ .Values.nussknacker.ververica.username | quote }}
password: {{ .Values.nussknacker.ververica.password | quote }}
remoteSyslogIp: {{ .Values.nussknacker.ververica.remoteSyslogIp | quote }}
remoteSyslogPort: {{ .Values.nussknacker.ververica.remoteSyslogPort }}
engineVersion: {{ .Values.nussknacker.ververica.engineVersion | quote }}
{{- if .Values.nussknacker.ververica.workspaceId }}
workspaceId: {{ .Values.nussknacker.ververica.workspaceId }}
{{- end }}
}
{{- else if eq .Values.nussknacker.mode "flink" }}
deploymentConfig: {
type: "flinkStreaming"
{{- /* Find easier way of passing it through values */}}
Expand Down
25 changes: 13 additions & 12 deletions src/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

global:
kafka:
name: kafka
port: 9092
zookeeper: &zookeeper_ports_config
ports:
client: 2181
schemaRegistry:
name: apicurio-registry
path: /apis/ccompat/v6/

replicaCount: 1

image:
Expand Down Expand Up @@ -166,9 +177,7 @@ postgresql:

zookeeper:
enabled: true
service:
ports:
client: 2181
service: *zookeeper_ports_config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How these changes are related with ververica?


kafka:
enabled: true
Expand All @@ -180,7 +189,7 @@ kafka:
enabled: false
externalZookeeper:
servers:
- "{{ .Release.Name }}-zookeeper:2181"
- "{{ .Release.Name }}-zookeeper:{{ .Values.global.zookeeper.ports.client }}"

apicurio-registry:
enabled: true
Expand Down Expand Up @@ -270,14 +279,6 @@ telegraf:
#We suppress default influxDB configuration from chart, as we cannot easily template influxdb url
outputs: []

global:
kafka:
name: kafka
port: 9092
schemaRegistry:
name: apicurio-registry
path: /apis/ccompat/v6/

nussknackerInitContainers: [ ]

#Extra resources to deploy
Expand Down