Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ververica configuration #120

Merged
merged 57 commits into from
Nov 3, 2023
Merged

Added ververica configuration #120

merged 57 commits into from
Nov 3, 2023

Conversation

pielas
Copy link
Contributor

@pielas pielas commented Oct 25, 2023

No description provided.

Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor feature request added

@@ -21,7 +21,15 @@ data:
restUrl: "{{ include "nussknacker.flinkJobManagerUrl" . }}"
queryableStateProxyUrl: "{{ include "nussknacker.flinkTaskManagerUrl" . }}"
} {{ tpl (.Values.nussknacker.flinkConfig | mustToJson) . }}

{{- else if eq .Values.nussknacker.mode "ververica" }}
deploymentConfig: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add worskspace as well

@pielas pielas merged commit 8770c7a into main Nov 3, 2023
@pielas pielas deleted the ververica-configuration branch November 3, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants