Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.18 fixes #168

Merged
merged 1 commit into from
Nov 19, 2024
Merged

1.18 fixes #168

merged 1 commit into from
Nov 19, 2024

Conversation

arkadius
Copy link
Member

  • build-deploy-verify.sh added postgres secret always to default namespace
  • authentication wasn't configured for telegraf
  • telegraf had wrong input urls
  • for (default) flink mode was used image tag without _scala-2.12 suffix
  • was wrong indention in src/README.md

@arkadius
Fixes:
5378582 
- build-deploy-verify.sh added postgres secret always to default k8s namespace
- authentication wasn't configured for telegraf
- telegraf had wrong input urls
- for (default) flink mode was used image tag without _scala-2.12 suffix
- was wrong indention in src/README.md
@arkadius arkadius requested a review from logichard November 18, 2024 20:59
logichard
logichard approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@logichard logichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadius arkadius merged commit d97d9bb into main Nov 19, 2024
7 checks passed
@arkadius arkadius deleted the 1.18-fixes branch November 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logichard logichard logichard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkadius @logichard