[Nu-7476] Add more info about failed deployment due to wrong cron con…

…figuration (#7479) * [Nu-7476] Add more info about failed deployment due to cron miss-configuration --------- Co-authored-by: Piotr Rudnicki <[email protected]> Co-authored-by: Dawid Poliszak <[email protected]>
TouK · Jan 22, 2025 · d4beb87 · d4beb87
1 parent 35c03d5
commit d4beb87
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/designer/client/src/http/HttpService.ts b/designer/client/src/http/HttpService.ts
@@ -349,10 +349,13 @@ class HttpService {
             .then(() => {
                 return { isSuccess: true };
             })
-            .catch((error) => {
+            .catch((error: AxiosError) => {
                 if (error?.response?.status != 400) {
                     return this.#addError(
-                        i18next.t("notification.error.failedToDeploy", "Failed to deploy {{processName}}", { processName }),
+                        i18next.t("notification.error.failedToDeploy", "Failed to deploy {{processName}} due to: {{axiosError}}", {
+                            processName,
+                            axiosError: handleAxiosError(error),
+                        }),
                         error,
                         true,
                     ).then(() => {

diff --git a/...rc/main/scala/pl/touk/nussknacker/engine/management/periodic/PeriodicProcessService.scala b/...rc/main/scala/pl/touk/nussknacker/engine/management/periodic/PeriodicProcessService.scala
@@ -137,9 +137,12 @@ class PeriodicProcessService(
       case e: SingleScheduleProperty => e.nextRunAt(clock).map(t => List((ScheduleName(None), t)))
     }
     (schedules match {
-      case Left(error) => Left(s"Failed to parse periodic property: $error")
-      case Right(scheduleDates) if scheduleDates.forall(_._2.isEmpty) => Left(s"No future date determined by $schedule")
-      case correctSchedules                                           => correctSchedules
+      case Left(error) => Left(s"Problem with parsing periodic property: $error")
+      case Right(scheduleDates) if scheduleDates.forall(_._2.isEmpty) =>
+        Left(
+          s"Problem with the scheduled date. It seems that a date from the past was configured in the CRON configuration."
+        )
+      case correctSchedules => correctSchedules
     }).left.map(new PeriodicProcessException(_))
   }