Skip to content

Commit

Permalink
more renames with word without
Browse files Browse the repository at this point in the history
  • Loading branch information
Pawel Czajka committed Jan 14, 2025
1 parent 93dcb08 commit d909987
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ object AssignabilityDeterminer {
isAssignable(from, to, StrictConversionChecker)

def isAssignableWithoutConversion(from: TypingResult, to: TypingResult): ValidatedNel[String, Unit] =
isAssignable(from, to, NoConversionConversionChecker)
isAssignable(from, to, WithoutConversionChecker)

private def isAssignable(from: TypingResult, to: TypingResult, conversionChecker: ConversionChecker) = {
(from, to) match {
Expand Down Expand Up @@ -226,7 +226,7 @@ object AssignabilityDeterminer {

}

private object NoConversionConversionChecker extends ConversionChecker {
private object WithoutConversionChecker extends ConversionChecker {

override def isConvertable(
from: SingleTypingResult,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ object typing {
/**
* Checks if the conversion to a given typingResult can be made without any conversion.
*/
final def canBeConvertedWithNoConversionTo(typingResult: TypingResult): Boolean =
final def canBeConvertedWithoutConversionTo(typingResult: TypingResult): Boolean =
AssignabilityDeterminer.isAssignableWithoutConversion(this, typingResult).isValid

def valueOpt: Option[Any]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ private[spel] class Typer(
// It would be hard to change implementation of .asMap extension so we partially turn off this feature of indexer conversion
// by allowing in typing only situations when map key type and indexer type are the same (though we have to allow
// indexing with unknown type)
case indexKey :: Nil if indexKey.canBeConvertedWithNoConversionTo(keyParam) => valid(valueParam)
case indexKey :: Nil if indexKey.canBeConvertedWithoutConversionTo(keyParam) => valid(valueParam)
case _ => invalid(IllegalIndexingOperation)
}
case d: TypedDict => dictTyper.typeDictValue(d, e).map(toNodeResult)
Expand Down

0 comments on commit d909987

Please sign in to comment.