[NU-1777] Separate classloader for deployment managers #7335
Conversation
| @@ -438,7 +456,8 @@ def assemblySettings( | |||
| includeScala: Boolean, | |||
| filterProvidedDeps: Boolean = true | |||
| ): List[Def.SettingsDefinition] = { | |||
| // This work around need to be optional because for designer module it causes excluding of scala lib (because we has there other work around for Idea classpath and provided deps) | |||
| // This work around need to be optional because for designer module it causes excluding of scala lib | |||
| // (because we have there other work around for Idea classpath and provided deps) | |||
There was a problem hiding this comment.
TBH I'm not sure what exact problem was solved this way and how to check if my change outdated it.
There was a problem hiding this comment.
I see that false was passed only for designer assembly. It looks like we have a fat jar for designer. I don't know if someone uses it :) but ... The only provided dependencies of designer where DMs so the default filterProvidedDeps = true should work the same so we can remove this condition
designer/server/src/main/scala/pl/touk/nussknacker/ui/api/description/NodesApiEndpoints.scala
Outdated
Show resolved
Hide resolved
| @@ -125,8 +128,6 @@ case class ClassLoaderModelData private ( | |||
| override val additionalConfigsFromProvider: Map[DesignerWideComponentId, ComponentAdditionalConfig], | |||
| // This property is for easier testing when for some reason, some jars with ComponentProvider are | |||
| // on the test classpath and CPs collide with other once with the same name. | |||
| // E.g. we add liteEmbeddedDeploymentManager as a designer provided dependency which also | |||
There was a problem hiding this comment.
I would remove these functions now and whole comment block
There was a problem hiding this comment.
I wanted to remove it but there is still some problem with ProcessConfigCreator implementations. Nevertheless, the lite Embedded deployment manager is not the problem anymore.
mk-software-pl
changed the base branch from
refactoring/NU-1777_nu_runtime_app
to
staging
* fix * rebuild backend * revert * resolve processDefinitionData reference issue * remove FE sorting of processDefinitionData * Sort classes on BE --------- Co-authored-by: Łukasz Bigorajski <[email protected]>
Describe your changes
managersDirsconfig settingincludeFlinkAndScala)Checklist before merge