Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1934] Ability to create json kafka source without schema registry #7483

Conversation

paw787878
Copy link
Contributor

@paw787878 paw787878 commented Jan 21, 2025

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

created: #7484
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@github-actions github-actions bot added the docs label Jan 22, 2025
@paw787878 paw787878 marked this pull request as ready for review January 22, 2025 14:24
Copy link
Member

@mslabek mslabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…conf-without-schema-with-not-creating-the-factory
@paw787878 paw787878 merged commit 14079a8 into staging Jan 23, 2025
19 checks passed
@paw787878 paw787878 deleted the 1934-kafka-source-conf-without-schema-with-not-creating-the-factory branch January 23, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants