Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NU-1999 Restrict description window to not take 100% height #7496

Merged

Conversation

Dzuming
Copy link
Contributor

@Dzuming Dzuming commented Jan 24, 2025

Describe your changes

  • Description window will be 35vh height max
  • update scrollbar style

Before:
image

After:
image

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Jan 24, 2025
Copy link
Contributor

created: #7501
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@github-actions github-actions bot added the docs label Jan 27, 2025
@Dzuming Dzuming requested a review from JulianWielga January 27, 2025 12:14
…dow-to-not-take-100%-height' into NU-1999-restrict-description-window-to-not-take-100%-height
@Dzuming Dzuming merged commit 9090c86 into staging Jan 30, 2025
14 checks passed
@Dzuming Dzuming deleted the NU-1999-restrict-description-window-to-not-take-100%-height branch January 30, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants