Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1923] Rename source 'sample-generator' to 'event-generator' and 'period' to 'schedule' #7502

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

mslabek
Copy link
Member

@mslabek mslabek commented Jan 27, 2025

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

created: #7503
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@mslabek mslabek force-pushed the nu-1923.rename-sample-generator branch from af63a06 to 630d8e5 Compare January 28, 2025 14:50
@mslabek mslabek marked this pull request as ready for review January 28, 2025 14:52
@mslabek mslabek merged commit b3eaf14 into staging Jan 30, 2025
19 of 20 checks passed
@mslabek mslabek deleted the nu-1923.rename-sample-generator branch January 30, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants