Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1977] [NU-1949] Window components fixes #7508

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

ForrestFairy
Copy link
Contributor

@ForrestFairy ForrestFairy commented Jan 28, 2025

Describe your changes

  • if more than 31 days is chosen in window components - the days won't be lost (previously after closing the node only remainder of 31 was left)
  • changes in default values for window components
    • for all - 1 hour is a default for windowLength
    • for aggregate-session - default value for endSessionCondition is now false

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Jan 28, 2025
@ForrestFairy ForrestFairy changed the title [NU-1977] Window components fixes [NU-1977] [NU-1949] Window components fixes Jan 28, 2025
@github-actions github-actions bot added the docs label Jan 28, 2025
@ForrestFairy ForrestFairy force-pushed the window-component-fixes branch 2 times, most recently from d3e7456 to 3891861 Compare January 29, 2025 09:34
@ForrestFairy ForrestFairy marked this pull request as ready for review January 29, 2025 09:35
@ForrestFairy ForrestFairy force-pushed the window-component-fixes branch from 4d7f413 to 92b323a Compare January 30, 2025 09:41
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForrestFairy ForrestFairy force-pushed the window-component-fixes branch from 12f979a to e9a221d Compare January 30, 2025 11:32
@ForrestFairy ForrestFairy merged commit bb92ddb into staging Jan 30, 2025
16 checks passed
@ForrestFairy ForrestFairy deleted the window-component-fixes branch January 30, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants