Fix different json representation in scheduling mechanism #7519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… database and manin Nu database (#7500)
piotrp
requested changes
Feb 6, 2025
...er/src/main/scala/db/migration/V1_062__ScenarioSchedulingTablesModificationsDefinition.scala
Outdated
Show resolved
Hide resolved
...er/src/main/scala/db/migration/V1_062__ScenarioSchedulingTablesModificationsDefinition.scala
Outdated
Show resolved
Hide resolved
...r/src/main/scala/pl/touk/nussknacker/ui/process/repository/PeriodicProcessesRepository.scala
Outdated
Show resolved
Hide resolved
…-representation-in-scheduling-engine
…-representation-in-scheduling-engine # Conflicts: # designer/server/src/main/scala/pl/touk/nussknacker/ui/process/repository/FetchingProcessRepository.scala
piotrp
approved these changes
Feb 7, 2025
mgoworko
deleted the
fix-different-json-representation-in-scheduling-engine
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The scenario graph stored as json in the db tables of the scheduling mechanism is different, than the one stored in process_versions table. It is already pre-resolved, for example fragments are expanded. The previous change in the periodic mechanism did not take that into account and was incorrent. We need to store this pre-resolved json. But there is one optimization possible, and now introduced in this PR in the new tables - cleaning this json when scenario is cancelled.
Checklist before merge