PMD bug - return all file violations not one per file

TouK · Apr 8, 2014 · 7adad64 · 7adad64
1 parent 433a5ea
commit 7adad64
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/main/java/pl/touk/sputnik/pmd/CollectorRenderer.java b/src/main/java/pl/touk/sputnik/pmd/CollectorRenderer.java
@@ -14,7 +14,6 @@
 import pl.touk.sputnik.review.Violation;
 
 import java.io.IOException;
-import java.util.Iterator;
 
 public class CollectorRenderer extends AbstractRenderer {
     private static final Logger LOG = LoggerFactory.getLogger(CollectorRenderer.class);
@@ -38,9 +37,7 @@ public void startFileAnalysis(DataSource dataSource) {
 
     @Override
     public void renderFileReport(Report report) throws IOException {
-        Iterator<RuleViolation> violations = report.iterator();
-        if (violations.hasNext()) {
-            RuleViolation ruleViolation = violations.next();
+        for (RuleViolation ruleViolation : report) {
             reviewResult.add(new Violation(ruleViolation.getFilename(), ruleViolation.getBeginLine(), ruleViolation.getDescription(), convert(ruleViolation.getRule().getPriority())));
         }
     }