Make Towny more resiliant to errors which come from having no Economy present on the server. #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
present on the server. Alter ConfirmationTransaction to no longer take in an Account in the constructor, instead it takes in a TownyObject, which will resolve an account. This prevents errors when non-Economy-enabled servers attempt to create a Confirmation with a cost set on it. Make TownyEconomyHandler#getFormattedBalance able to handle returning a formatted balance when the Economy is not active. Add prettyMoney method to BaseCommand, use it throughout the command classes to make things look cleaner.
Warriorrrr
reviewed
Dec 20, 2023
| * @param loggedMessage The message logged in the money.csv file. | ||
| * @param insufficientFundsMessage Transatable which will display the cannot pay message. | ||
| */ | ||
| public ConfirmationTransaction(Supplier<Double> costSupplier, Account payee, String loggedMessage, Translatable insufficientFundsMessage) { | ||
| public ConfirmationTransaction(Supplier<Double> costSupplier, TownyObject townyObject, String loggedMessage, Translatable insufficientFundsMessage) { |
There was a problem hiding this comment.
This can just accept an EconomyHandler instance which resident/town/nation all implement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Alter ConfirmationTransaction to no longer take in an Account in the constructor, instead it takes in a TownyObject, which will resolve an account. This prevents errors when non-Economy-enabled servers attempt to create a Confirmation with a cost set on it.
Make TownyEconomyHandler#getFormattedBalance able to handle returning a formatted balance when the Economy is not active.
Add prettyMoney method to BaseCommand, use it throughout the command classes to make things look cleaner.
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.