Skip to content

Commit

Permalink
Merge pull request #424 from Tresjs/bugfix/411-linter-is-breaking-som…
Browse files Browse the repository at this point in the history
…e-props

fix: vue attrs hyphenation issues
  • Loading branch information
JaimeTorrealba authored May 17, 2024
2 parents ca86e5e + 82fe77b commit 77b2220
Show file tree
Hide file tree
Showing 7 changed files with 234 additions and 231 deletions.
1 change: 0 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export default tresLintConfig({
}, {
rules: {
'style/max-statements-per-line': 'off',
'vue/attribute-hyphenation': 'off',
'jsdoc/check-alignment': 'off',
},
})
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"devDependencies": {
"@release-it/conventional-changelog": "^8.0.1",
"@tresjs/core": "^3.2.1",
"@tresjs/eslint-config": "^1.0.0",
"@tresjs/eslint-config": "^1.1.0",
"@tweakpane/core": "^1.1.9",
"@types/node": "^20.12.10",
"@types/three": "^0.164.0",
Expand Down
2 changes: 1 addition & 1 deletion playground/components.d.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* eslint-disable */
/* prettier-ignore */
// @ts-nocheck
// Generated by unplugin-vue-components
// Read more: https://github.com/vuejs/core/pull/3399
export {}

/* prettier-ignore */
declare module 'vue' {
export interface GlobalComponents {
AkuAku: typeof import('./src/components/AkuAku.vue')['default']
Expand Down
18 changes: 9 additions & 9 deletions playground/src/pages/staging/SkyDemo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const gl = {
toneMappingExposure: 1,
}
const [turbidity, rayleigh, mieCoefficient, mieDirectionalG, elevation, azimuth, distance, exposure] = useControls({
const { turbidity, rayleigh, mieCoefficient, mieDirectionalG, elevation, azimuth, distance, exposure } = useControls({
turbidity: { value: 3.4, min: 0, max: 20, step: 0.1 },
rayleigh: { value: 3, min: 0, max: 4, step: 0.1 },
mieCoefficient: { value: 0.005, min: 0, max: 0.1, step: 0.001 },
Expand All @@ -28,17 +28,17 @@ const [turbidity, rayleigh, mieCoefficient, mieDirectionalG, elevation, azimuth,
<TresLeches class="important-fixed important-left-2 important-w-90" />
<TresCanvas
v-bind="gl"
:tone-mapping-exposure="exposure.value.value"
:tone-mapping-exposure="exposure.value"
>
<TresPerspectiveCamera :position="[0, 100, 2000]" />
<Sky
:elevation="elevation.value.value"
:azimuth="azimuth.value.value"
:mie-coefficient="mieCoefficient.value.value"
:mie-directional-g="mieDirectionalG.value.value"
:rayleigh="rayleigh.value.value"
:turbidity="turbidity.value.value"
:distance="distance.value.value"
:elevation="elevation.value"
:azimuth="azimuth.value"
:mie-coefficient="mieCoefficient.value"
:mie-directional-g="mieDirectionalG.value"
:rayleigh="rayleigh.value"
:turbidity="turbidity.value"
:distance="distance.value"
/>
<OrbitControls
:enable-pan="false"
Expand Down
Loading

0 comments on commit 77b2220

Please sign in to comment.