Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove camera warning log on default camera creation #916

Merged
merged 3 commits into from
Feb 6, 2025
Merged

fix: remove camera warning log on default camera creation #916

merged 3 commits into from
Feb 6, 2025

Conversation

alvarosabu
Copy link
Member

No description provided.

@alvarosabu alvarosabu self-assigned this Feb 5, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 8f908d3
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/67a469dd47a34e00080feeb2
😎 Deploy Preview https://deploy-preview-916--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu alvarosabu added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 5, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 5, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/core@916

commit: a7b285e

@alvarosabu alvarosabu mentioned this pull request Feb 5, 2025
Closed
andretchen0
andretchen0 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Glad to have less noise in the console.

@alvarosabu alvarosabu merged commit 5d490b4 into main Feb 6, 2025
3 checks passed
@alvarosabu alvarosabu deleted the bugfix/remove-camera-warning branch February 6, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andretchen0 andretchen0 andretchen0 approved these changes

Assignees

@alvarosabu alvarosabu

Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarosabu @andretchen0