Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently don't list or number tables without a caption #198

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

chrisfenner
Copy link
Member

@chrisfenner chrisfenner commented Nov 18, 2024

There was a bug in the "should we not number this table" logic:

  • The use of caption and caption* (controls links in list of tables) wasn't always consistent with the \addtocounter{table}{-1} workaround (undoes the incrementation of the counter)
  • As a result, many tables that shouldn't have been numbered (in the TPM spec) were getting numbered

This change updates the logic to be more clear:

A table is not numbered, and not included in the list of tables, if:

  • .unnumbered .unlisted (traditional way to omit stuff from the TOC) OR
  • there is no caption

Edge case corollary: a table that is .unnumbered .unlisted should not be cross-referenced.

Fixes #194

@chrisfenner chrisfenner marked this pull request as ready for review November 18, 2024 22:29
@chrisfenner chrisfenner merged commit 519b783 into main Nov 18, 2024
2 checks passed
@chrisfenner chrisfenner deleted the fix-table-numbering branch November 18, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables with {.plain .unnumbered .unlisted} still cause skips in the table numbers
1 participant