chore(2631): Refactor storage service to separate channel and message logic #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islathehut
commented
Jan 28, 2025
packages/backend/src/nest/connections-manager/connections-manager.service.ts
Outdated
Show resolved
Hide resolved
islathehut
force-pushed
the
feat/2631-message-channel-storage-refactor
branch
from
645ccb1 to
03cf584
Compare
adrastaea
approved these changes
Feb 4, 2025
| try { | ||
| return await this.getStore().add(encryptedMessage) | ||
| } catch (e) { | ||
| throw new CompoundError(`Could not append message (entry not allowed to write to the log)`, e) |
There was a problem hiding this comment.
This may be existing behavior, but when we hit this error, the message is still displayed in the timeline (grayed out as you might expect for an unsent message, but when you close and reopen the app, it is no longer grayed out which is misleading as to whether it was actually sent)
There was a problem hiding this comment.
Yea that's existing behavior we need to deal with. We can't know if a message has been sent or not right now, as far as I know.
islathehut
added a commit
that referenced
this pull request
Feb 4, 2025
… logic (#2713) * Create channels service and small fix for loading chain on app start * Separate logic further into channelstore and messagesservice * Add temp placeholders for encryption/decryption * Minor clean up * Expand messages service, tweak getting messages, fix/add tests * Fix subscribing not getting old messages on join * Fix peer list not updating * Add compounderror * Update auth * Update CHANGELOG.md
islathehut
added a commit
that referenced
this pull request
Feb 7, 2025
… logic (#2713) * Create channels service and small fix for loading chain on app start * Separate logic further into channelstore and messagesservice * Add temp placeholders for encryption/decryption * Minor clean up * Expand messages service, tweak getting messages, fix/add tests * Fix subscribing not getting old messages on join * Fix peer list not updating * Add compounderror * Update auth * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: