github-avoid-http-files #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 83.14% 83.76% +0.61%
==========================================
Files 217 217
Lines 12536 12550 +14
==========================================
+ Hits 10423 10512 +89
+ Misses 1742 1663 -79
- Partials 371 375 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuvenharrison
requested review from
effoeffi
and removed request for
effoeffi
effoeffi
added a commit
to oasdiff/oasdiff
that referenced
this pull request
Feb 1, 2024
* add flag to control colorful output (Tufin#433) * Bump github.com/oasdiff/go-common from 0.2.27 to 0.2.28 (Tufin#444) * color-flag completion (Tufin#447) * Bump cloud.google.com/go from 0.110.10 to 0.111.0 (Tufin#448) * prevent---color-with-non-text-formats (Tufin#449) * upgrade-to-kin-openapi-v0.122.0 (Tufin#450) * diff-add-exclude-elements-options (Tufin#454) * remove-hardcoded-quotes (Tufin#455) * Correct int messages (Tufin#456) * fix test (Tufin#457) * add qr code (Tufin#458) * typo * github-annotations-with-api (Tufin#452) * add source file to github (Tufin#459) * Change sample sunset date to self-explain that it's YYYY-MM-DD format (Tufin#460) * github-avoid-http-files (Tufin#462) * Update ALLOF.md * flatten command - fix wrong Title and Description values (Tufin#464) * flatten command - prune oneOf field on circular references (Tufin#466) * lower-min-go-ver (Tufin#471) * update Breaking Changes to Enum Values * Bump cloud.google.com/go from 0.111.0 to 0.112.0 (Tufin#472) * delta (Tufin#473) * add property name to the response's type/format change message (Tufin#477) * documentation (Tufin#478) * Update DELTA.md (Tufin#480) --------- Co-authored-by: Reuven Harrison <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: effoeffi <[email protected]> Co-authored-by: Maciej Lewiński <[email protected]> Co-authored-by: Omer E <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR githubactions format would always include
file=<file>in the annotations.However, the file is only relevant if it is local in which case the GitHub annotation can be clicked to see the relevant file diff.
Specs that were given as a URL or stdin should not be included in GitHub annotations.
The PR enhances githubactions format to include
file=<file>only when the file is in the local filesystem.To achieve this I changed ApiChange.Source type from string to load.Source which has an
IsFilemethod.Side effects:
Todo: