Skip to content

Commit

Permalink
Revert "Initial AbstractMCMC.step should not sample (#366)"
Browse files Browse the repository at this point in the history
This reverts commit 32d0446.
  • Loading branch information
torfjelde authored Jan 13, 2025
1 parent 32d0446 commit 0010a98
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions src/abstractmcmc.jl
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ function AbstractMCMC.step(

# Compute next transition and state.
state = HMCState(0, t, metric, κ, adaptor)
# Return the initial transition and state.
return Transition(t.z, merge(stat(t), (is_adapt = false,))), state
# Take actual first step.
return AbstractMCMC.step(rng, model, spl, state; kwargs...)
end

function AbstractMCMC.step(
Expand Down Expand Up @@ -260,13 +260,10 @@ function (cb::HMCProgressCallback)(
κ = state.κ
tstat = t.stat
isadapted = tstat.is_adapt
# The initial transition will not much information beyond the `is_adapt` field.
if haskey(tstat, :numerical_error)
if isadapted
cb.num_divergent_transitions_during_adaption[] += tstat.numerical_error
else
cb.num_divergent_transitions[] += tstat.numerical_error
end
if isadapted
cb.num_divergent_transitions_during_adaption[] += tstat.numerical_error
else
cb.num_divergent_transitions[] += tstat.numerical_error
end

# Update progress meter
Expand Down

0 comments on commit 0010a98

Please sign in to comment.