Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect mapvcat Zygote adjoint #362

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Remove incorrect mapvcat Zygote adjoint #362

merged 3 commits into from
Jan 15, 2025

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Jan 14, 2025

We define a Zygote.@adjoint for mapvcat manually. This seems unnecessary to me. Moreover, the implementation is wrong, since it ignores the vcat part of mapvcat. I've added a test that would have caught this.

Closes #361

@mhauru mhauru requested a review from willtebbutt January 14, 2025 17:44
@mhauru mhauru mentioned this pull request Jan 14, 2025
Closed
yebai
yebai approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mhauru!

@mhauru
Copy link
Member Author

mhauru commented Jan 15, 2025

Thanks @yebai. I bumped the patch version as well.

@yebai yebai merged commit df3695c into master Jan 15, 2025
31 of 33 checks passed
@yebai yebai deleted the mhauru/mapvcat-zygote branch January 15, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

@willtebbutt willtebbutt Awaiting requested review from willtebbutt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zygote is broken for Stacked transformations
2 participants
@mhauru @yebai