Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for check_model on arrays with undef #607

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "DynamicPPL"
uuid = "366bfd00-2699-11ea-058f-f148b4cae6d8"
version = "0.26.1"
version = "0.26.2"


[deps]
Expand Down
10 changes: 9 additions & 1 deletion src/debug_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,15 @@ end

# tilde
_has_missings(x) = ismissing(x)
_has_missings(x::AbstractArray) = any(ismissing, x)
function _has_missings(x::AbstractArray)
# Can't just use `any` because `x` might contain `undef`.
for i in eachindex(x)
if isassigned(x, i) && _has_missings(x[i])
return true
end
end
return false
end

# assume
function record_pre_tilde_assume!(context::DebugContext, vn, dist, varinfo)
Expand Down
12 changes: 12 additions & 0 deletions test/debug_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,16 @@

@test !DynamicPPL.has_static_constraints(model)
end

@testset "vector with `undef`" begin
# Source: https://github.com/TuringLang/Turing.jl/pull/2218
@model function demo_undef(ns...)
x = Array{Real}(undef, ns...)
@. x ~ Normal(0, 2)
end
for ns in [(2,), (2, 2), (2, 2, 2)]
model = demo_undef(ns...)
@test check_model(model; error_on_failure=true)
end
end
end
Loading