Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted diagrams to Mermaid #645

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Converted diagrams to Mermaid #645

merged 3 commits into from
Aug 29, 2024

Conversation

shravanngoswamii
Copy link
Member

@shravanngoswamii shravanngoswamii commented Aug 22, 2024 •
edited
Loading

Old Diagrams with Graphviz New Diagrams with Mermaid
image
image
image
image
image

Let me know if any changes are required! And mermaid diagrams are just looking small in this comment because they are screenshots, they are fine on site!

Closes #642

@shravanngoswamii shravanngoswamii mentioned this pull request Aug 22, 2024
Closed
@shravanngoswamii
Copy link
Member Author

Preview: https://turinglang.org/DynamicPPL.jl/previews/PR645/internals/transformations/

yebai
yebai approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shravanngoswamii; looks good to me!

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 10515089817

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 76.663%
Totals Coverage Status
Change from base Build 10487776343: -0.8%
Covered Lines: 2697
Relevant Lines: 3518
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10515089817

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.508%
Totals Coverage Status
Change from base Build 10487776343: 0.0%
Covered Lines: 2712
Relevant Lines: 3499
💛 - Coveralls

@yebai yebai enabled auto-merge August 29, 2024 11:11
@yebai yebai added this pull request to the merge queue Aug 29, 2024
Merged via the queue into master with commit 264c456 Aug 29, 2024
14 of 23 checks passed
@yebai yebai deleted the shravanngoswamii/mermaid-diagram branch August 29, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

@torfjelde torfjelde Awaiting requested review from torfjelde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert doc diagrams to Mermaid
3 participants
@shravanngoswamii @coveralls @yebai